worker: add missing initialization #41421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing initialization reported by coverity Signed-off-by: Michael Dawson <[email protected]>
nodejs-github-bot
added
c++
tniessen
approved these changes
Jan 7, 2022
cjihrig
approved these changes
Jan 7, 2022
20 tasks
addaleax
requested changes
Jan 8, 2022
There was a problem hiding this comment.
uv_thread_t is an opaque type, we should not rely on the fact that 0 may currently be a valid initailizer for it.
Usage of tid_ is restricted to the condition that thread_joined_ is false, and conversely thread_joined_ is only set to false when tid_ is initialized. Consequently, this seems to be a false positive.
Edit: To be clear: This also reduces readability because initializing tid_ makes it looks like the variable can always be accessed, even when the thread is not running, which is not valid usage of it. However, I think we’re using C++17 now, so maybe we could drop thread_joined_ and instead make tid_ an std::optional<uv_thread_t>?
18 tasks
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jan 9, 2022
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jan 9, 2022
|
PR with that suggestion: #41453 |
|
Ok, I'll check the coverity report after the change proposed in #41453 and if it still reports an issue we can flag it as a false positive. |
This was referenced Jan 12, 2022
aduh95
pushed a commit
that referenced
this pull request
Jan 14, 2022
Refs: #41421 PR-URL: #41453 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jan 16, 2022
Refs: #41421 PR-URL: #41453 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
mawaregetsuka
pushed a commit
to mawaregetsuka/node
that referenced
this pull request
Jan 17, 2022
Refs: nodejs#41421 PR-URL: nodejs#41453 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
|
#41453 seems to have resolve the warning, closing. |
thedull
pushed a commit
to thedull/node
that referenced
this pull request
Jan 18, 2022
Refs: nodejs#41421 PR-URL: nodejs#41453 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs#41421 PR-URL: nodejs#41453 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing initialization reported by coverity
Signed-off-by: Michael Dawson [email protected]